New IDP sso/slo binding params which deprecate :embed_sign#610
Merged
pitbulk merged 5 commits intoSAML-Toolkits:masterfrom Aug 16, 2021
Merged
New IDP sso/slo binding params which deprecate :embed_sign#610pitbulk merged 5 commits intoSAML-Toolkits:masterfrom
pitbulk merged 5 commits intoSAML-Toolkits:masterfrom
Conversation
…_binding`, and +deprecates `settings.security[:embed_sign]`. If specified, new binding parameters will be used in place of `:embed_sign` to determine how to handle SAML message signing (`HTTP-POST` embeds signature and `HTTP-Redirect` does not.) In addition, the `IDPMetadataParser` `parse`, `parse_to_hash` and `parse_to_array` methods now retrieve `idp_sso_service_binding` and `idp_slo_service_binding`. Lastly, for convenience you may now use the Symbol aliases `:post` and `:redirect` for any `settings.*_binding` parameter.
Collaborator
Author
|
@pitbulk ready for your review |
Collaborator
Author
|
Conflicts resolved |
pitbulk
approved these changes
Aug 16, 2021
Collaborator
Author
|
@pitbulk really appreciate the prompt response! Thank you! |
Collaborator
|
Thank you for your recent contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #606
Adds settings.idp_sso_service_binding and
settings.idp_slo_service_binding, and deprecatessettings.security[:embed_sign]. If specified, new binding parameters will be used in place of:embed_signto determine how to handle SAML message signing (HTTP-POSTembeds signature andHTTP-Redirectdoes not.)In addition:
IDPMetadataParserparse,parse_to_hashandparse_to_arraymethods now retrieveidp_sso_service_bindingandidp_slo_service_binding.:postand:redirectfor anysettings.*_bindingparameter.Settingsclass had needlessly verbose code. I've cleaned them up.